Remove coach node #2101
Closed
Remove coach node #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automated style fixes Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com>
Please enter a commit message to explain why this merge is necessary,
sid-parikh
requested changes
Sep 28, 2023
| @@ -95,6 +99,10 @@ void AgentActionClient::world_state_callback(const rj_msgs::msg::WorldState::Sha | |||
| last_world_state_ = std::move(world_state); | |||
| } | |||
|
|
|||
| void AgentActionClient::play_state_callback(const rj_msgs::msg::PlayState::SharedPtr& msg) { | |||
| return; | |||
There was a problem hiding this comment.
Hey amogh, can you also change the AC & Position to get play state data from this topic? the callback is empty right now; we should be forwarding it to position. I know position doesn't use play state data right now, but that's okay
|
This last commit calculates global overrides in the Planner Node (planner_node.cpp) |
|
Look at PR #2131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Referee PlayState subscription to all the files that use CoachState and don't have play state already (which is just Agent Action Client). This is part of the plan to remove CoachNode.